Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : complete progress page #88

Merged
merged 8 commits into from
Dec 8, 2024
Merged

feat : complete progress page #88

merged 8 commits into from
Dec 8, 2024

Conversation

SamTheKorean
Copy link
Contributor

@SamTheKorean SamTheKorean commented Nov 23, 2024 •
edited
Loading

데모 영상

Screen.Recording.2024-12-03.at.11.01.06.PM.mov

체크리스트

  • 이슈가 연결되어 있나요?
  • 배포 후 브라우저 콘솔에 경고나 오류가 있나요?

@SamTheKorean SamTheKorean self-assigned this Nov 23, 2024
@SamTheKorean SamTheKorean linked an issue Nov 23, 2024 that may be closed by this pull request
Entire Progress Page #80
Closed
@SamTheKorean SamTheKorean changed the title Complete progress page feat : complete progress page Nov 23, 2024
@SamTheKorean
Copy link
Contributor Author

SamTheKorean commented Nov 23, 2024 •
edited
Loading

Screenshot 2024-11-23 at 3 59 32 PM
디테일한 ui나 데이터를 가공해줘야하는데 데모를 위해 해당 테스크들은 뒤로 미루고 지금까지 나온 부분까지 공유드립니다! 내부에 있는 링크들 포함 문제들 전부 실제 데이터와 연결했습니다!

@DaleSeo
Copy link
Contributor

DaleSeo commented Nov 23, 2024 •
edited
Loading

디테일한 ui나 데이터를 가공해줘야하는데 데모를 위해 해당 테스크들은 뒤로 미루고 지금까지 나온 부분까지 공유드립니다! 내부에 있는 링크들 포함 문제들 전부 실제 데이터와 연결했습니다!

@SamTheKorean 프로그레스 페이지까지 데모를 하기에는 너무 PR이 늦게 올라온 거 아닌가 싶어요 😓 너무 서두르다가 다른 부작용을 일으키기 보다는 우리가 비현실적인 목표를 설정했다는 것을 인정하고, 너무 무리하지 말고 오늘은 아쉽지만 되는데까지 데모를 하면 어떨까요?

@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from 05f675a to c90a923 Compare December 4, 2024 01:54
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from c90a923 to 18e4279 Compare December 4, 2024 01:58
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from 65d49f0 to d66afc3 Compare December 4, 2024 04:00
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from d66afc3 to 468db6a Compare December 4, 2024 04:03
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from 468db6a to ce2cb6b Compare December 4, 2024 04:09
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from ce2cb6b to 8133827 Compare December 4, 2024 04:11
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from 246930d to f8fc300 Compare December 4, 2024 04:35
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from f8fc300 to cbc04bd Compare December 4, 2024 04:39
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from cbc04bd to ff04562 Compare December 4, 2024 04:44
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from ff04562 to 4801e4a Compare December 4, 2024 04:46
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from 4801e4a to 5d9c041 Compare December 4, 2024 04:51
DaleSeo
DaleSeo reviewed Dec 7, 2024
View reviewed changes
src/constants/problems.ts Outdated Show resolved Hide resolved
src/components/Table/Table.stories.tsx Outdated Show resolved Hide resolved
src/components/Table/Table.tsx Outdated Show resolved Hide resolved
src/components/Table/Table.tsx Outdated Show resolved Hide resolved
src/components/Table/Table.tsx Show resolved Hide resolved
src/api/services/types.ts Outdated Show resolved Hide resolved
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch 2 times, most recently from f6431ad to b7f50c1 Compare December 8, 2024 03:54
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from b7f50c1 to d50492c Compare December 8, 2024 04:33
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from d50492c to 59ad74f Compare December 8, 2024 04:34
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from 59ad74f to c22ee28 Compare December 8, 2024 04:37
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from c22ee28 to 5de086a Compare December 8, 2024 04:43
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from 5de086a to e52a3ca Compare December 8, 2024 05:00
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from e52a3ca to 631b609 Compare December 8, 2024 05:01
@SamTheKorean SamTheKorean force-pushed the sam/complete-progress-page branch from 631b609 to e3e7bbe Compare December 8, 2024 05:18
@SamTheKorean
Copy link
Contributor Author

시간 내어 피드백 주셔서 감사합니다! ui 밑 코드 관련 피드백 적용가능한 부분은 바로 적용하고 의문이 드는 부분은 코멘트 남겼습니다!

DaleSeo
DaleSeo approved these changes Dec 8, 2024
View reviewed changes
Copy link
Contributor

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피드백 반영해주셔서 감사합니다! 🙇

@SamTheKorean SamTheKorean merged commit bfff29b into main Dec 8, 2024
4 of 5 checks passed
@SamTheKorean SamTheKorean deleted the sam/complete-progress-page branch December 8, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunjae95 Sunjae95 Sunjae95 left review comments

@sounmind sounmind sounmind left review comments

@DaleSeo DaleSeo DaleSeo approved these changes

Assignees

@SamTheKorean SamTheKorean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Entire Progress Page
4 participants
@SamTheKorean @DaleSeo @sounmind @Sunjae95